Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vite 5 removes the
https: boolean
type and as it doesn't have much use by default. A plugin or manual configuration is always needed forhttps
to actually work (e.g. certs). (vitejs/vite#14681)This PR updates the types breaking change caused by it. It uses
@ts-ignore
so it works on both Vite 4 and 5. Theas any
is also needed so theconfig
hook doesn't error by TS due to incorrect type returned by the function.Extra notes unrelated to PR
It seems like before (Vite 4), users could do
vite --https
orhttps: true
invite.config.js
to get the right certs generate bylaravel-vite-plugin
. In Vite 5, this isn't possible anymore except ifhttps: {}
invite.config.js
. Though it isn't quite exactly documented in the laravel docs.Just want to note this in case you want to handle this differently in the future. For example, the
detectTls
could be used to enablehttps
internally. Right now it doesn't due to the existing logic here:vite-plugin/src/index.ts
Lines 163 to 166 in 7abca67