Don't report errors when using \nocite{*}

See #964.
latex-lsp · Nov 19, 2023 · a7520ce · a7520ce
1 parent 867dbc9
commit a7520ce
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+
+### Fixed
+
+- Do not report `undefined reference` errors when using `\nocite{*}` ([#964](https://github.com/latex-lsp/texlab/issues/964))
+
 ## [5.11.0] - 2023-11-05
 
 ### Added

diff --git a/crates/diagnostics/src/citations.rs b/crates/diagnostics/src/citations.rs
@@ -47,7 +47,8 @@ fn detect_undefined_citations<'db>(
         .collect();
 
     for citation in &data.semantics.citations {
-        if !entries.contains(citation.name.text.as_str()) {
+        let name = citation.name_text();
+        if name != "*" && !entries.contains(name) {
             let diagnostic = Diagnostic {
                 range: citation.name.range,
                 data: DiagnosticData::Tex(TexError::UndefinedCitation),