feat: polling data source now supports one shot configuration #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanderson-ld
commented
Dec 20, 2024
...hdarkly-android-client-sdk/src/main/java/com/launchdarkly/sdk/android/LDClientInterface.java
Show resolved
Hide resolved
tanderson-ld
commented
Dec 20, 2024
| ConnectivityManager.fetchAndSetData(fetcher, context, dataSourceUpdateSink, | ||
| resultCallback, logger); | ||
| numberOfPollsRemaining--; // decrementing even when we have unlimited polls has no consequence | ||
| } |
There was a problem hiding this comment.
For reviewers: Decrementing with unlimited polls will underflow after 20,428 years. Seemed worth the simplified implementation.
tanderson-ld
commented
Dec 20, 2024
...hdarkly-android-client-sdk/src/main/java/com/launchdarkly/sdk/android/PollingDataSource.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: polling data source now supports one shot configuration
fix: polling data source no longer reports initialized=true incorrectly when rate limiting delays first poll
END_COMMIT_OVERRIDE
Requirements
I have added test coverage for new or changed functionality
TODO
I have followed the repository's pull request submission guidelines
I have validated my changes against all supported platform versions
TODO
Describe the solution you've provided
Adds polling data source one shot mode. Updated data source to support providing the max number of polls to make.
Updated builder to calculate number of polls to make based on one shot configuration.