chore: cleaning up github actions paths, fixing publish docs params #8
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,5 +33,5 @@ runs: | |
| uses: launchdarkly/gh-actions/actions/[email protected] | ||
| with: | ||
| test_service_port: 8000 | ||
| extra_params: '--status-timeout=360' | ||
| token: ${{ inputs.token }} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,13 +2,14 @@ name: Manual Publish Package | |
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| pkg_workspace: | ||
| description: 'The package to publish' | ||
| required: true | ||
| type: choice | ||
| options: | ||
| - pkgs/sdk/client | ||
| - pkgs/sdk/server | ||
| - pkgs/telemetry | ||
| dry_run: | ||
| description: 'Is this a dry run. If so no package will be published.' | ||
| type: boolean | ||
|
|
@@ -23,68 +24,41 @@ on: | |
|
|
||
| jobs: | ||
| build: | ||
| runs-on: macos-latest | ||
| permissions: | ||
| id-token: write | ||
| contents: write | ||
| outputs: | ||
| full-release-hashes: ${{ steps.full-release.outputs.hashes }} | ||
|
There was a problem hiding this comment. For reviewers: Commonizing |
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Env from project's Env file | ||
| shell: bash | ||
| run: echo "$(cat ${{ inputs.pkg_workspace }}/github_actions.env)" >> $GITHUB_ENV | ||
|
|
||
| - uses: ./.github/actions/full-release | ||
| id: full-release | ||
| with: | ||
| workspace_path: ${{ env.WORKSPACE_PATH }} | ||
| project_file: ${{ env.PROJECT_FILE }} | ||
| build_output_path: ${{ env.BUILD_OUTPUT_PATH }} | ||
| test_project_file: ${{ env.TEST_PROJECT_FILE }} | ||
| dll_name: ${{ env.BUILD_OUTPUT_DLL_NAME }} | ||
|
There was a problem hiding this comment. For reviewers: the setup env action helps compartmentalize all the path strings |
||
| dry_run: ${{ inputs.dry_run }} | ||
| aws_role: ${{ vars.AWS_ROLE_ARN }} | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| release-provenance: | ||
|
|
||
| needs: ['build'] | ||
| permissions: | ||
| actions: read | ||
| id-token: write | ||
| contents: write | ||
| uses: slsa-framework/slsa-github-generator/.github/workflows/[email protected] | ||
| if: | | ||
| (inputs.generate_provenance == 'Generate' || (inputs.generate_provenance == 'Default' && github.ref_name == 'main')) | ||
| with: | ||
| base64-subjects: "${{ needs.build.outputs.full-release-hashes }}" | ||
| upload-assets: true | ||
| provenance-name: ${{inputs.pkg_workspace}}_provenance.intoto.jsonl | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,57 +1,44 @@ | ||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| pkg_workspace: | ||
| description: 'The package to publish' | ||
| required: true | ||
| type: choice | ||
| options: | ||
| - pkgs/sdk/client | ||
| - pkgs/sdk/server | ||
| - pkgs/telemetry | ||
|
|
||
| name: Publish Docs | ||
| jobs: | ||
| build-publish: | ||
| runs-on: macos-latest | ||
| permissions: | ||
| contents: write # Needed in this case to write github pages. | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Env from project's Env file | ||
| shell: bash | ||
| run: echo "$(cat ${{ inputs.pkg_workspace }}/github_actions.env)" >> $GITHUB_ENV | ||
|
|
||
| - id: build | ||
| name: Build and Test SDK | ||
| uses: ./.github/actions/ci | ||
| with: | ||
| project_file: ${{ env.PROJECT_FILE }} | ||
| test_project_file: ${{ env.TEST_PROJECT_FILE }} | ||
|
|
||
| - id: build-docs | ||
| name: Build Documentation | ||
| uses: ./.github/actions/build-docs | ||
| with: | ||
| workspace_path: ${{ env.WORKSPACE_PATH }} | ||
|
|
||
| - id: publish-docs | ||
| name: Publish Documentation | ||
| uses: ./.github/actions/publish-docs | ||
| with: | ||
| workspace_path: ${{ env.WORKSPACE_PATH }} | ||
| token: ${{secrets.GITHUB_TOKEN}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,13 +7,15 @@ on: | |
|
|
||
| jobs: | ||
| release-please: | ||
| runs-on: macos-latest | ||
|
|
||
| outputs: | ||
| package-sdk-server-released: ${{ steps.release.outputs['pkgs/sdk/server--release_created'] }} | ||
| package-sdk-server-tag_name: ${{ steps.release.outputs['pkgs/sdk/server--tag_name'] }} | ||
| package-sdk-server-telemetry-released: ${{ steps.release.outputs['pkgs/telemetry--release_created'] }} | ||
| package-sdk-server-telemetry-tag_name: ${{ steps.release.outputs['pkgs/telemetry--tag_name'] }} | ||
| package-sdk-client-released: ${{ steps.release.outputs['pkgs/sdk/client--release_created'] }} | ||
| package-sdk-client-tag_name: ${{ steps.release.outputs['pkgs/sdk/client--tag_name'] }} | ||
| tag_name: ${{ steps.release.outputs.tag_name }} | ||
|
|
||
| steps: | ||
|
|
@@ -24,7 +26,7 @@ jobs: | |
| target-branch: ${{ github.ref_name }} | ||
|
|
||
| release-sdk-server: | ||
| runs-on: macos-latest | ||
| needs: release-please | ||
| permissions: | ||
| id-token: write | ||
|
|
@@ -35,55 +37,96 @@ jobs: | |
| hashes: ${{ steps.full-release.outputs.hashes }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Env from project's Env file | ||
| shell: bash | ||
| run: echo "$(cat pkgs/sdk/server/github_actions.env)" >> $GITHUB_ENV | ||
|
|
||
| - uses: ./.github/actions/full-release | ||
| id: full-release | ||
| with: | ||
| workspace_path: ${{ env.WORKSPACE_PATH }} | ||
| project_file: ${{ env.PROJECT_FILE }} | ||
| build_output_path: ${{ env.BUILD_OUTPUT_PATH }} | ||
| test_project_file: ${{ env.TEST_PROJECT_FILE }} | ||
| dll_name: ${{ env.BUILD_OUTPUT_DLL_NAME }} | ||
| dry_run: false | ||
| aws_role: ${{ vars.AWS_ROLE_ARN }} | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
|
There was a problem hiding this comment. For reviewers: Moved provenance tasks to the bottom for organization. Made the diff weird. |
||
| release-telemetry: | ||
| runs-on: macos-latest | ||
| needs: release-please | ||
| permissions: | ||
| id-token: write | ||
| contents: write | ||
| pull-requests: write | ||
| if: ${{ needs.release-please.outputs.package-sdk-server-telemetry-released == 'true'}} | ||
| outputs: | ||
| hashes: ${{ steps.full-release.outputs.hashes }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Env from project's Env file | ||
| shell: bash | ||
| run: echo "$(cat pkgs/telemetry/github_actions.env)" >> $GITHUB_ENV | ||
|
|
||
| - uses: ./.github/actions/full-release | ||
| id: full-release | ||
| with: | ||
| workspace_path: ${{ env.WORKSPACE_PATH }} | ||
| project_file: ${{ env.PROJECT_FILE }} | ||
| build_output_path: ${{ env.BUILD_OUTPUT_PATH }} | ||
| test_project_file: ${{ env.TEST_PROJECT_FILE }} | ||
| dll_name: ${{ env.BUILD_OUTPUT_DLL_NAME }} | ||
| dry_run: false | ||
| aws_role: ${{ vars.AWS_ROLE_ARN }} | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| release-sdk-client: | ||
| runs-on: macos-latest | ||
| needs: release-please | ||
| permissions: | ||
| id-token: write | ||
| contents: write | ||
| pull-requests: write | ||
| if: ${{ needs.release-please.outputs.package-sdk-client-released == 'true'}} | ||
| outputs: | ||
| hashes: ${{ steps.full-release.outputs.hashes }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Env from project's Env file | ||
| shell: bash | ||
| run: echo "$(cat pkgs/sdk/client/github_actions.env)" >> $GITHUB_ENV | ||
|
|
||
| - uses: ./.github/actions/full-release | ||
| id: full-release | ||
| with: | ||
| workspace_path: ${{ env.WORKSPACE_PATH }} | ||
| project_file: ${{ env.PROJECT_FILE }} | ||
| build_output_path: ${{ env.BUILD_OUTPUT_PATH }} | ||
| test_project_file: ${{ env.TEST_PROJECT_FILE }} | ||
| dll_name: ${{ env.BUILD_OUTPUT_DLL_NAME }} | ||
| dry_run: false | ||
| aws_role: ${{ vars.AWS_ROLE_ARN }} | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| # TODO: refactor provenance | ||
| release-sdk-server-provenance: | ||
|
There was a problem hiding this comment. For reviewers: Moved provenance tasks to the bottom for organization. Made the diff weird. |
||
| needs: ['release-please', 'release-sdk-server'] | ||
| permissions: | ||
| actions: read | ||
| id-token: write | ||
| contents: write | ||
| uses: slsa-framework/slsa-github-generator/.github/workflows/[email protected] | ||
| with: | ||
| base64-subjects: "${{ needs.release-sdk-server.outputs.hashes }}" | ||
| upload-assets: true | ||
| upload-tag-name: ${{ needs.release-please.outputs.package-sdk-server-tag_name }} | ||
| provenance-name: ${{ format('LaunchDarkly.ServerSdk-{0}_provenance.intoto.jsonl', needs.release-please.outputs.package-sdk-server-tag_name) }} | ||
|
|
||
|
|
||
| release-telemetry-provenance: | ||
| needs: ['release-please', 'release-telemetry'] | ||
| permissions: | ||
|
|
@@ -96,3 +139,5 @@ jobs: | |
| upload-assets: true | ||
| upload-tag-name: ${{ needs.release-please.outputs.package-sdk-server-telemetry-tag_name }} | ||
| provenance-name: ${{ format('LaunchDarkly.ServerSdk.Telemetry-{0}_provenance.intoto.jsonl', needs.release-please.outputs.package-sdk-server-telemetry-tag_name) }} | ||
|
|
||
| # TODO: add client provenance | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,6 @@ jobs: | |
| build-and-test: | ||
| strategy: | ||
| matrix: | ||
| os: [macos-latest] | ||
| fail-fast: false | ||
| runs-on: ${{ matrix.os }} | ||
|
|
@@ -23,6 +22,10 @@ jobs: | |
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Env from project's Env file | ||
| shell: bash | ||
| run: echo "$(cat pkgs/sdk/client/github_actions.env)" >> $GITHUB_ENV | ||
|
|
||
| - uses: launchdarkly/gh-actions/actions/[email protected] | ||
| name: Get secrets | ||
| with: | ||
|
|
@@ -34,15 +37,17 @@ jobs: | |
|
|
||
| - uses: ./.github/actions/ci | ||
| with: | ||
| project_file: ${{ env.PROJECT_FILE}} | ||
| test_project_file: ${{ env.TEST_PROJECT_FILE}} | ||
|
|
||
| - uses: ./.github/actions/contract-tests | ||
| with: | ||
| service_project_file: ${{ env.CONTRACT_TEST_PROJECT_FILE}} | ||
| service_dll_file: ${{ env.CONTRACT_TEST_DLL_FILE}} | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - uses: ./.github/actions/build-docs | ||
| with: | ||
| workspace_path: ${{ env.WORKSPACE_PATH}} | ||
|
|
||
| # TODO: resolve issue with emulator and device tests | ||
|
There was a problem hiding this comment. For reviewers: This is an existing TODO in the client-sdk repo that I am migrating here so we don't forget about it. |
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: Using macos-latest since mac is the lowest common denominator for platforms that supports all the client SDK target frameworks.