-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce T_COSE_OPT_ENABLE_NON_AEAD #284
base: dev
Are you sure you want to change the base?
Introduce T_COSE_OPT_ENABLE_NON_AEAD #284
Conversation
…PT_ENABLE_NON_AEAD to avoid unintentional use of them
I'm going to hold on this for a few days to see the outcome of the errata proposal separately in email. Thanks! Really appreciate the contribution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate the PR and like the design (and test coverage!)
Would like to add a specific error code (error codes cost nothing) to help the caller figure out better what went wrong and to find the solution.
Also, some wording changes. Maybe discuss in email instead of here.
Thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reflected all your comments. Please check the updated files.
This PR mitigates AEAD to non-AEAD downgrade attacks by warning the library uses to comply with RFC 9459.
Non AEAD algorithms are disabled by default, and will be enabled only when the
T_COSE_OPT_ENABLE_NON_AEAD
option is specified by the library caller.The library callers using AES-CTR or AES-CBC will lose the backward compatibility, but it is crucial avoiding them to be vulnerable.
For example, they must be updated from
to