Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've have the date portion of this PR fixed locally since checks oh, November 2016, but I never got around to actually submitting a PR :). Better late than never?
This PR improves using
rsync_tmbackup.sh
in the msys2 environment (alternative to cygwin which creates binaries which don't depend on the cygwin dll). Date parsing to detect old backups to-be-purged and detecting an already-running backup for the directory is now functional.Detecting existing processes requires
procps
, as it does on cygwin (pacman -S procps
). Runningprocps
has a few minor warnings that are unavoidable for now:As I can't test cygwin at this moment, I don't want to modify the commands shared between msys and cygwin to detect existing backups for now- just in case there's subtle command-line breakage (It shouldn't cause any problems to remove a "
-
", but you never know!).