Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Msys(2) Improvements #127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Msys(2) Improvements #127

wants to merge 2 commits into from

Conversation

cr1901
Copy link
Contributor

@cr1901 cr1901 commented Jul 20, 2018

I've have the date portion of this PR fixed locally since checks oh, November 2016, but I never got around to actually submitting a PR :). Better late than never?

This PR improves using rsync_tmbackup.sh in the msys2 environment (alternative to cygwin which creates binaries which don't depend on the cygwin dll). Date parsing to detect old backups to-be-purged and detecting an already-running backup for the directory is now functional.

Detecting existing processes requires procps, as it does on cygwin (pacman -S procps). Running procps has a few minor warnings that are unavoidable for now:

$ ./msys.sh
2.4+ kernel w/o ELF notes? -- report this
Warning: bad ps syntax, perhaps a bogus '-'? See http://procps.sf.net/faq.html

As I can't test cygwin at this moment, I don't want to modify the commands shared between msys and cygwin to detect existing backups for now- just in case there's subtle command-line breakage (It shouldn't cause any problems to remove a "-", but you never know!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant