Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Search Dark Mode Friendly #5883

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

THEBOSS0369
Copy link

@THEBOSS0369 THEBOSS0369 commented Sep 15, 2024

This PR fixes #5734

Description

I have added some changes so that the input looks like more dark friendly. The changes for style has been done for Intergration Page, Home Page and Blog Page. The style is same as the style in layer5/news page. Below are the ss for the changes made.

main page
main page
blog

Notes for Reviewers
This PR is same as this one #5881 . It is made because of DCO error not resolving.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: THEBOSS0369 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Sep 15, 2024

🚀 Preview for commit ae8e3af at: https://66e6cb30f79a9a88c715ccb7--layer5.netlify.app

@Ashparshp
Copy link
Contributor

@THEBOSS0369, Thank you for your contribution!
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

I'm adding it as an agenda item to the meeting minutes || meeting link.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wouldn't want to change theme colors @THEBOSS0369

@vishalvivekm
Copy link
Member

@THEBOSS0369
Sharing the links form our discussion in websites meeting

@vishalvivekm
Copy link
Member

Also, will you please remove commits not pertinent to the issue ?

@THEBOSS0369
Copy link
Author

@THEBOSS0369
Sharing the links form our discussion in websites meeting

Thanks for sharing this!! 🙂🙂

@THEBOSS0369
Copy link
Author

Also, will you please remove commits not pertinent to the issue ?

Sure! I will remove the changes from searchbox. Js and apply the changes in gridestyle. Js

@vishalvivekm
Copy link
Member

Also, will you please remove commits not pertinent to the issue ?

Sure! I will remove the changes from searchbox. Js and apply the changes in gridestyle. Js

I was referring to these Commits:
Screenshot_20240917-084243

@THEBOSS0369
Copy link
Author

Also, will you please remove commits not pertinent to the issue ?

Sure! I will remove the changes from searchbox. Js and apply the changes in gridestyle. Js

I was referring to these Commits:
Screenshot_20240917-084243

Ohhhh, i get it now! I didn't commited those changes but can you tell me how do i remove those commits like do i have to revert back or any other way.

@THEBOSS0369
Copy link
Author

THEBOSS0369 commented Sep 17, 2024

@vishalvivekm Can you confirm that i have to do Delete File right??
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Dark-mode friendly support for search input field
6 participants