-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theming to toolbar options #645
Conversation
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
This looks largely good. There are two things I'd like to point out though. |
Hi @sudhanshutech, thank you for raising this fix, looks we missed covering this on any sites call. |
@sudhanshutech thoughts on @Rexford74's feedback? |
@leecalcote i tried the requested design of checkbox , here is the checbox screenshot. What i discovered from this is we should stick with our existing checkbox which is single border in a unchecked state. Let me know your thoughts // @Rexford74 |
@sudhanshutech demo this issue today, please. |
Ah sorry i missed, I will do surely next time. |
…o toolbar/options Signed-off-by: Sudhanshu Dasgupta <[email protected]>
…o toolbar/options Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Notes for Reviewers
This PR adds theme to toolbar components which were missing.
Signed commits