Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Catalog Card and add flip effect #720

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

sudhanshutech
Copy link
Member

@sudhanshutech sudhanshutech commented Aug 16, 2024

Notes for Reviewers

This PR fixes #
{97846736-D8B3-4600-A25A-4FA95EE91337}
{017DB255-0006-484F-A983-539E9D1F1661}

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Sudhanshu Dasgupta <[email protected]>
@sudhanshutech
Copy link
Member Author

do not merge this now

@amitamrutiya
Copy link
Contributor

@sudhanshutech @SAHU-01 is this ready for merge?

@sudhanshutech
Copy link
Member Author

no @amitamrutiya its not ready to merge, there is some work left on the back side of card to incorporate the styles of technologies and some other minute styles

@amitamrutiya
Copy link
Contributor

@sudhanshutech one request could you please prioritize this and merge this so I can use those cards in the extension repo as well? I want to use this in the empty kanvas catalog modal.

@sudhanshutech
Copy link
Member Author

@amitamrutiya go for it

Copy link
Contributor

@amitamrutiya amitamrutiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  if (!shouldFlip) {
    return (
      <DesignCard shouldFlip={shouldFlip} isDetailed={isDetailed} outerStyles={outerStyles}>
        <DesignInnerCard shouldFlip={shouldFlip} className="innerCard">
          <CardFront shouldFlip={shouldFlip} isDetailed={isDetailed}>
            {children}
          </CardFront>
        </DesignInnerCard>
      </DesignCard>
    );
  }

Can you also add this code? Some of the cards without flip functionality behave differently.

Additionally, your PR has a different position for the back side version, so could you please check that as well?

@leecalcote
Copy link
Member

@amitamrutiya directly commit to this branch. Take it over.

@amitamrutiya amitamrutiya merged commit 8895222 into layer5io:master Oct 10, 2024
8 checks passed
@sudhanshutech
Copy link
Member Author

Sounds good @amitamrutiya 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants