Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage by tiny amount #7

Open
wants to merge 6 commits into
base: main-test
Choose a base branch
from
Open

Increase coverage by tiny amount #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4d352d2
Increase coverage by tiny amount
lbianchi-lbl Jan 20, 2021
fd43882
Tweak workflow skip conditions
lbianchi-lbl Jan 20, 2021
1b19ec0
Fix missing parens
lbianchi-lbl Jan 20, 2021
9611771
Make run examples conditional as well
lbianchi-lbl Jan 20, 2021
09d8b2e
Try using label with dedicated prefix as trigger
lbianchi-lbl Jan 20, 2021
7fd4449
Debug event/context conditions
lbianchi-lbl Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@ on:
- requested
pull_request:
types:
# it probably makes more sense to use the review requested feature on one of the bot accounts
# - labeled
- review_requested
- labeled

defaults:
run:
Expand All @@ -24,8 +22,7 @@ jobs:
# NOTE: the name of the special label is hardcoded here
# it would be better to extract it to a more global location, e.g. the workflow-level env context,
# but the env context is not available in job-level if expressions (only step-level ones)
# if: (github.event.name != 'pull_request') || contains(github.event.label.name, 'approved')
if: (github.event.name != 'pull_request') || contains(github.event.users.*.login, 'idaes-debug')
if: (github.event.action != 'labeled') || (github.event.label.name == 'CI:run-integration')
runs-on: ubuntu-latest
steps:
- name: Notify
Expand All @@ -47,6 +44,7 @@ jobs:
- name: Display debug info
run: |
echo '${{ toJSON(matrix) }}'
echo '${{ toJSON(github) }}'
echo '${{ toJSON(github.event) }}'
- uses: actions/checkout@v2
- name: Set up Python
Expand All @@ -63,6 +61,7 @@ jobs:
markexpr: integration
examples:
name: Run examples (py${{ matrix.python-version }}/${{ matrix.os }})
needs: [check-skip]
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand Down
2 changes: 2 additions & 0 deletions idaes/tests/test_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,10 @@ def test_ver_class():
assert str(v) == '1.2.3'
v = ver.Version(1, 2, 3, 'beta', 1)
assert str(v) == '1.2.3.b1'
assert list(v) == [1, 2, 3, 'beta', 1]
v = ver.Version(1, 2, 3, 'development')
assert str(v) == '1.2.3.dev'
assert list(v) == [1, 2, 3, 'development']
pytest.raises(ValueError, ver.Version, 1, 2, 3, 'howdy')


Expand Down