Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add field basic input wrapper component and example #449

Merged
merged 71 commits into from
Jan 27, 2025

Conversation

Rahien
Copy link
Collaborator

@Rahien Rahien commented Dec 17, 2024

Description

Allow adding and removing fields to forms (if the form is wrapped in an EditableForm component and the feature flag is on. On by default in development mode).

image

image

How to test

Currently, the only field where this is active is the extra info for a mandataris. So go to a schepen and test it out there. Try adding, refreshing, removing fields

Links to other PR's

app/components/editable-form.js Show resolved Hide resolved
app/components/editable-form.js Show resolved Hide resolved
app/components/generate-custom-field-button.hbs Outdated Show resolved Hide resolved
app/components/generate-custom-field-button.hbs Outdated Show resolved Hide resolved
app/components/generate-custom-field-button.js Outdated Show resolved Hide resolved
config/environment.js Show resolved Hide resolved
Copy link
Contributor

@JonasVanHoof JonasVanHoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good only the remove can be done before saving it

app/components/rdf-input-fields/custom-field-wrapper.hbs Outdated Show resolved Hide resolved
app/components/rdf-input-fields/custom-field-wrapper.js Outdated Show resolved Hide resolved
@Rahien Rahien force-pushed the karel/lmb-333-create-form-extensions branch from 47efdea to 5f2a3df Compare January 7, 2025 13:11
Copy link
Contributor

@JonasVanHoof JonasVanHoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two silly additions for the eyes 👀

app/components/generate-custom-field-button.hbs Outdated Show resolved Hide resolved
app/components/rdf-input-fields/custom-field-wrapper.hbs Outdated Show resolved Hide resolved
@JonasVanHoof
Copy link
Contributor

I can't seem to find a comment about that the extra info of the custom field is not being visible in the mandataris-extra-info-card.

Maybe this is something for another ticket

@Rahien
Copy link
Collaborator Author

Rahien commented Jan 9, 2025

I can't seem to find a comment about that the extra info of the custom field is not being visible in the mandataris-extra-info-card.

Maybe this is something for another ticket

There is a ticket for this in the next sprint

@Rahien Rahien requested a review from JonasVanHoof January 9, 2025 14:48
@Rahien Rahien force-pushed the karel/lmb-333-create-form-extensions branch from 14ba654 to 439b213 Compare January 20, 2025 08:33
karel kremer and others added 26 commits January 24, 2025 11:39
…an object, only one consumer has to be added to the component
@Rahien Rahien force-pushed the karel/lmb-333-create-form-extensions branch from e581239 to cfecf42 Compare January 24, 2025 10:53
@Rahien Rahien merged commit 9f19884 into master Jan 27, 2025
2 checks passed
@Rahien Rahien deleted the karel/lmb-333-create-form-extensions branch January 27, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants