Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use minimal version of evaluator.h for LC #10

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

czgdp1807
Copy link
Collaborator

No description provided.

@certik
Copy link
Contributor

certik commented Dec 13, 2023

I've seen this PRIxPTR error many times:

/home/runner/micromamba-root/envs/lc/include/llvm/Object/SymbolicFile.h:48:31: error: expected ')'
  OS << "(" << format("0x%08" PRIxPTR, D.p) << " (" << format("0x%08x", D.d.a)

I always forget what the issue is.

@czgdp1807
Copy link
Collaborator Author

LLVM seems broken on linux for this particular case. I am trying to workaround it. Since we don't need JIT functionality for now. We have more important things to do. Once we have a fix we can back to the original code without workarounds.

@czgdp1807
Copy link
Collaborator Author

Merging. Everything is unified across Ubuntu and macOS for LC. Whenever this LLVM issue is fixed we can switch back to evaluator.cpp.

@czgdp1807 czgdp1807 merged commit 85411b5 into lcompilers:main Dec 13, 2023
2 checks passed
@czgdp1807 czgdp1807 changed the title Use clang and clang++ for compilation in Ubuntu Use minimal version of evaluator.h for LC Dec 13, 2023
@certik
Copy link
Contributor

certik commented Dec 13, 2023

Thanks!

@czgdp1807 czgdp1807 deleted the lc_12 branch December 13, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants