Reset tmp to nullptr everytime its used to avoid using corrupt values
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV: Add OneTimeUseASRNode<T> for resetting value once read. Helps in avoiding usage of corrupt values generated from previous statements, expressions. Currently used for tmp member of AST visitor. DEV: Add support NotEq operator.
|
In Release mode we can then implement a version that does not set the result to nullptr, so there shouldn't be any overhead at runtime in Release mode. And it will still get reset in Debug mode, to catch bugs early. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Achieved using
OneTimeUseASRNode<T>for resetting value once read. Helps in avoiding usage of corrupt values generated from previous statements, expressions by making sure whenevergetis called thetmp.nodesets tonullptr. That way whenever we analyse the next expression/statementtmp.nodeisnullptr, so we will start afresh and won't be able to use anything from previous expression/statement even by mistake.Addition of this uncovered a bug which I fixed in this PR itself.