Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same command line parser as LPython and LFortran #66

Merged
merged 4 commits into from
Jan 14, 2024
Merged

Use the same command line parser as LPython and LFortran #66

merged 4 commits into from
Jan 14, 2024

Conversation

Shaikh-Ubaid
Copy link
Collaborator

@Shaikh-Ubaid Shaikh-Ubaid commented Jan 13, 2024 •
edited
Loading

fixes #35

Shaikh-Ubaid
Shaikh-Ubaid commented Jan 13, 2024
View reviewed changes
integration_tests/CMakeLists.txt
RUN(NAME array_21.cpp LABELS gcc llvm NOFAST
EXTRA_ARGS --extra-arg=-I${CONDA_PREFIX}/include)
RUN(NAME array_22.cpp LABELS gcc llvm NOFAST
EXTRA_ARGS --extra-arg=-I${CONDA_PREFIX}/include)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above test cases are intact. Just the EXTRA_ARGS is removed.

@Shaikh-Ubaid
Copy link
Collaborator Author

The reference tests simply got renamed.

@Shaikh-Ubaid Shaikh-Ubaid marked this pull request as ready for review January 13, 2024 20:31
@Shaikh-Ubaid
Copy link
Collaborator Author

Ready.

certik
certik approved these changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! I think this looks great and good to merge. We can iron out any regressions later.

Go ahead and merge it.

@Shaikh-Ubaid Shaikh-Ubaid merged commit 100959a into lcompilers:main Jan 14, 2024
2 checks passed
@Shaikh-Ubaid Shaikh-Ubaid deleted the use_lfortran_driver branch January 14, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the same command line parser as LPython and LFortran
2 participants
@Shaikh-Ubaid @certik