CI: Add initial version #2
Conversation
|
@certik the CI does not seem to run. Do we need to enable GitHub actions for this repository? |
Shaikh-Ubaid
force-pushed
the
ci
branch
2 times, most recently
from
d19b899 to
8a9ad1f
Compare
I am temporarily working here Shaikh-Ubaid#1. |
|
From https://github.com/Shaikh-Ubaid/lpython-conda-testing/actions/runs/6282537317/job/17062084700?pr=1, semantic error: Function 'field' is not declared and not intrinsic
--> /home/runner/work/lpython-conda-testing/lpython-conda-testing/lpython/integration_tests/array_expr_03.py:8:16
|
8 | a: i8[4] = field(default_factory=lambda: empty(4, dtype=int8))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Note: if any of the above error or warning messages are not clear or are lacking
context please report it to us (we consider that a bug that must be fixed).
semantic error: array accepts only 1 argument for now, got 3107819[61](https://github.com/Shaikh-Ubaid/lpython-conda-testing/actions/runs/6282537317/job/17062084700?pr=1#step:7:62)94145634 arguments instead.
[ 1%] Built target variable_decl_02
--> /home/runner/work/lpython-conda-testing/lpython-conda-testing/lpython/integration_tests/array_expr_04.py:5:17
|
5 | a8: i8[4] = array([127, -127, 3, 111], dtype=int8)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Note: if any of the above error or warning messages are not clear or are lacking
context please report it to us (we consider that a bug that must be fixed).
gmake[2]: *** [CMakeFiles/array_expr_03.dir/build.make:74: array_expr_03.o] Error 2
[ 1%] Built target array_expr_01
gmake[1]: *** [CMakeFiles/Makefile2:936: CMakeFiles/array_expr_03.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....
gmake[2]: *** [CMakeFiles/array_expr_04.dir/build.make:74: array_expr_04.o] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:9[62](https://github.com/Shaikh-Ubaid/lpython-conda-testing/actions/runs/6282537317/job/17062084700?pr=1#step:7:63): CMakeFiles/array_expr_04.dir/all] Error 2
[ 1%] Generating array_expr_06.o
[ 1%] Generating array_expr_05.o
[ 1%] Built target array_expr_02
semantic error: array accepts only 1 argument for now, got 31078196194145[63](https://github.com/Shaikh-Ubaid/lpython-conda-testing/actions/runs/6282537317/job/17062084700?pr=1#step:7:64)4 arguments instead.
--> /home/runner/work/lpython-conda-testing/lpython-conda-testing/lpython/integration_tests/array_expr_06.py:5:19
|
5 | a32: f32[4] = array([127, -127, 3, 111], dtype=float32)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^I think at the moment we need to make a new release with the latest LPython. |
|
I drafted a new release here https://github.com/lcompilers/lpython/releases/tag/untagged-41add913e85eff81ce2d. Shall I publish it? |
|
Yes, call it 0.20.0. We should only increase the patch version for patches (such as those that will be discovered by this repository). |
environment.yml
Outdated
| - lpython=0.19.0 | ||
| - nodejs | ||
| - make | ||
| - cmake |
There was a problem hiding this comment.
Put exact versions for all dependencies.
There was a problem hiding this comment.
Sure, got it.
.github/workflows/CI.yml
Outdated
| shell: bash -e -l {0} | ||
| run: | | ||
| git clone https://github.com/lcompilers/lpython.git | ||
| git checkout 2293972e5ce377787d134541f8363ae441030b76 |
There was a problem hiding this comment.
For easiness of maintenance, perhaps here we can just checkout the corresponding "tag" from environment.yml, so:
git checkout v0.19.0
The git hash is more robust, but here I think we will be updating this version very often, so I think it's fine to use the tag. We assume that we do not change tags once published (we've never done that so far), so it should be robust.
In other cases when we use a branch, that is fragile, since branches move.
|
@certik Do you know why the CI here does not run? |
|
You have to merge it first, and possibly setup in Settings. You should have the rights to do it. If not, please ping me. |
Got it.
I can see the following options in the repository settings. I could not find options related to GitHub actions in these. 
|
|
As it seems approved, I am (squash) merging this temporarily. I will fix this further in a separate/new PR. |
towards #1