Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CI to pass by not running tests on Windows #5

Merged
merged 6 commits into from
Oct 8, 2023

Conversation

Shaikh-Ubaid
Copy link
Collaborator

No description provided.

@certik
Copy link
Contributor

certik commented Oct 8, 2023

The error message on macOS:

[ 24%] Built target loop_06
semantic error: String method not implemented: join
  --> /Users/runner/work/lpython-conda-testing/lpython-conda-testing/lpython/integration_tests/test_str_01.py:52:15
   |
[ 24%] Generating test_str_02.o
52 |     res:str = a.join(p)
[ 24%] Linking C executable if_03
   |               ^^^^^^^^^ 

Signals either mismatch of a test and a conda binary package, or a bug in lpython.

@certik
Copy link
Contributor

certik commented Oct 8, 2023

The log says:

HEAD is now at 2293972e5 Merge pull request #2334 from Shaikh-Ubaid/changes_from_lf

Which is the correct commit for v0.20.0. So it should be the matching test.

@Shaikh-Ubaid
Copy link
Collaborator Author

Shaikh-Ubaid commented Oct 8, 2023

Which is the correct commit for v0.20.0. So it should be the matching test.

Yes, it should be matching the test. But it seems it does not, which is probably why it fails.

@Shaikh-Ubaid
Copy link
Collaborator Author

str.join() was added recently. Unsure why the integration tests corresponding to the latest main are getting executed at the CI.

@certik
Copy link
Contributor

certik commented Oct 8, 2023

Something is wrong:

            git clone https://github.com/lcompilers/lpython.git
            git fetch https://github.com/lcompilers/lpython.git --tags -f

Shouldn't the second command be executed after cd lpython? I think you are checking out the tags into the root directory, which contains the https://github.com/lcompilers/lpython-conda-testing repository, then checking it out, all good. But then you cd to lpython, which has the latest main, so it is testing features that we don't have in conda yet.

Instead, the way it has to work is to cd lpython right after clone. Btw, there are flags you can pass to clone to get the tags, in fact they might be downloaded by default? Either way, do everything in that directory and git checkout v0.20.0 I think is fine, that way it's each to change.

@Shaikh-Ubaid Shaikh-Ubaid changed the title Allow CI to pass by not running integration tests on Windows Allow CI to pass by not running tests on Windows Oct 8, 2023
@Shaikh-Ubaid
Copy link
Collaborator Author

Either way, do everything in that directory and git checkout v0.20.0 I think is fine, that way it's each to change.

Yes, fixed it.

@Shaikh-Ubaid Shaikh-Ubaid merged commit 4b43039 into lcompilers:main Oct 8, 2023
3 checks passed
@Shaikh-Ubaid Shaikh-Ubaid deleted the ci_working branch October 8, 2023 18:51
Shaikh-Ubaid added a commit to Shaikh-Ubaid/lfortran-conda-testing that referenced this pull request Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants