-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of str.partition()
with tuples
#1619
Conversation
LPython CI build is successful. Can you please review @Thirumalai-Shaktivel @czgdp1807 and @Smit-create? |
Otherwise I think this is fine. |
07aa21c
to
0903c9d
Compare
This looks good, left some more comments. Keep this current design, no classes. Just a little more refactoring based on my comments above. |
b997d2d
to
9eb96cb
Compare
Can you review @certik and @Thirumalai-Shaktivel @Smit-create @czgdp1807 ? I incorporated all the changes. PS: This was a really good PR for me as I learnt a lot through this. |
Should I refactor of all the other functions like |
Made the changes. @czgdp1807 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good to me.
The history should be polished or squashed.
Why did the build fail? I submitted a successful build PR. @certik @czgdp1807 |
@harshsingh-24 I think it failed due to #1645 (comment). |
Functionality
: Split the string at the first occurrence ofseparator
, and return a 3-tuple containing the part before the separator, the separator itself, and the part after the separator. If the separator is not found, return a 3-tuple containing the string itself, followed by two empty strings.ValueError
is raised. TheValueError
function needs to be refactored further.PS: Had a nice experience with
git merge
and resolving conflicts 😀