Add join method in str

[Agent-Hellboy]

No description provided.

[certik]

I think this is great, thank you @Agent-Hellboy. I left a minor suggestion.

[certik]

You also need to update our reference tests using: ./run_tests -u and commit the changes.

[OculusMode]

Can be directly iterated on the list itself, this way it can be worked on iterables easily(in future). Every iterable can be called using next so I think that would be more better.

something like this can be more cleaner I think.

for ele in range(list_):
    res+=ele

[certik]

If it works, we can use the simpler syntax. LPython doesn't yet work for user defined iterables, but eventually it will I think.

[OculusMode]

thats not reliable. You are always assuming your str len will be 1 here, It should fail when str has len more than 1. You can prob use res[len(str):]

[certik]

Good catch! I think even better would be something like:

if len(lis) == 0: return ""
res = lis[0]
for i in range(1, len(lis)):
    res += s + lis[i]
return res

[OculusMode]

That works too, altho as long as there plans of iterables, part of len will probably be removed regardless.

[Agent-Hellboy]

You also need to update our reference tests using: ./run_tests -u and commit the changes.

okay, the CI tests are failing because of this, I didn't understand update our reference tests, what does run_tests -u do?

-u flag is not there in run_tests

    parser.add_argument("-j", "-n", "--no_of_threads", type=int,
                help="Parallel testing on given number of threads")
    parser.add_argument("-b", "--backends", nargs="*", default=["llvm", "cpython"],
                type=str, help="Test the requested backends (%s), default: llvm, cpython" % \
                        ", ".join(SUPPORTED_BACKENDS))
    parser.add_argument("-f", "--fast", action='store_true',
                help="Run supported tests with --fast")
    return parser.parse_args()

[Agent-Hellboy]

I guess, I need to parse over asr nodes of the list argument passed inside the join method to check if only str is passed or not
https://github.com/lcompilers/lpython/pull/2354/files#diff-147457a9117ab6d023c02f9a359d6060c248c4216cfcb47b1fafd17d885063feR6672
I am still exploring the codebase, I will try to do it in coming days

[certik]

It's the one in the root directory:

(lp) repos/lpython(main) $ ./run_tests.py --help
usage: run_tests.py [-h] [-u] [-l] [-t [TEST ...]] [-b [BACKEND ...]] [-v]
                    [--exclude-test [TEST ...]]
                    [--exclude-backend [BACKEND ...]] [--no-llvm]
                    [--skip-run-with-dbg] [-s] [--no-color]

LPython Test Suite

options:
  -h, --help            show this help message and exit
  -u, --update          update all reference results
...

[certik]

I guess, I need to parse over asr nodes of the list argument passed inside the join method to check if only str is passed or not

That's needed for error messages. But first let's get the two existing tests that you added (they both look great) to pass all CI. After CI passes, then we can either merge, or you can add some tests for errors.

[Thirumalai-Shaktivel]

Let's test test_str_join2

[Thirumalai-Shaktivel]

LGTM, Thank you!

[Thirumalai-Shaktivel]

We can test more cases like empty strings, more items in the list (more than 3), and so on...
This can be done in the subsequent PRs.

[certik]

I think this looks good, thanks!

[Shaikh-Ubaid]

I just noticed this. @Agent-Hellboy this is amazing! I really appreciate it. Keep up the great work.

[Shaikh-Ubaid]

I just noticed this. Here, I think passed_int should be named list_of_str (or something similar). (@Agent-Hellboy I remember we were experimenting with it by passing an integer.)

I think you can fix the above in your new PR #2364. You can just make the rename a separate commit.

[certik]

Go ahead and create an issue, so that we don't forget.

[Agent-Hellboy]

created #2365