Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class_test_3 #2782

Merged
merged 5 commits into from
Jul 23, 2024
Merged

class_test_3 #2782

merged 5 commits into from
Jul 23, 2024

Conversation

tanay-man
Copy link
Contributor

@tanay-man tanay-man commented Jul 20, 2024 •
edited
Loading

fixes #2781

@tanay-man tanay-man marked this pull request as draft July 20, 2024 13:52
@tanay-man tanay-man changed the title Tests for classes class_test_3 Jul 21, 2024
@tanay-man tanay-man marked this pull request as ready for review July 21, 2024 14:58
@tanay-man
Copy link
Contributor Author

@Thirumalai-Shaktivel can you please review?

Thirumalai-Shaktivel
Thirumalai-Shaktivel reviewed Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@Thirumalai-Shaktivel Thirumalai-Shaktivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

integration_tests/class_03.py
def main():
c : Circle = Circle(1.0)
c.circle_print()
c.radius = 1.5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an assert statement here?

Thirumalai-Shaktivel
Thirumalai-Shaktivel approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@Thirumalai-Shaktivel Thirumalai-Shaktivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Thirumalai-Shaktivel Thirumalai-Shaktivel enabled auto-merge (squash) July 23, 2024 15:35
@Thirumalai-Shaktivel Thirumalai-Shaktivel merged commit c5be7c7 into lcompilers:main Jul 23, 2024
15 checks passed
@tanay-man tanay-man deleted the tests branch July 24, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thirumalai-Shaktivel Thirumalai-Shaktivel Thirumalai-Shaktivel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method calling doesn't work inside methods
2 participants
@tanay-man @Thirumalai-Shaktivel