LSP: Add support for goto def in compiler for VSCode extension #982
Conversation
| token_name = "\"" + yystype.string.str() + "\""; | ||
| } | ||
| return token_name; | ||
| } |
There was a problem hiding this comment.
Should we call this function in pickle_token, so that we do not repeat the code?
| if (input_in_scope_identifier( | ||
| index, | ||
| std::make_pair<int, int>(locations[i].first, locations[i].last))) { |
There was a problem hiding this comment.
I would just do:
| if (input_in_scope_identifier( | |
| index, | |
| std::make_pair<int, int>(locations[i].first, locations[i].last))) { | |
| if (locations[i].first <= index && index <= locations[i].last) { | |
| } |
And remove input_in_scope_identifier.
| } | ||
| std::vector<LFortran::LPython::document_symbols> symbol_lists; | ||
| LFortran::LPython::document_symbols loc; | ||
| for (auto &a : x.result->m_global_scope->get_scope()) { |
There was a problem hiding this comment.
This will only be able to lookup symbols at global scope. Rather, we need to use resolve_symbol to lookup the symbol in the scoped symbol table. For that, we need to know which ASR node we are in.
To do that, we need to implement "index" -> ASR node calculation.
This will have to be one by the "overlapping intervals" problem, as we discussed some time ago.
| @@ -859,6 +1005,7 @@ int main(int argc, char *argv[]) | |||
| // LSP specific options | |||
| app.add_flag("--show-errors", show_errors, "Show errors when LSP is running in the background"); | |||
| app.add_flag("--show-document-symbols", show_document_symbols, "Show symbols in lpython file"); | |||
| app.add_option("--goto-def", goto_def_index, "Pass index for GoTo Definition"); | |||
There was a problem hiding this comment.
VSCode calls it Go to Definition, so maybe we can call this option --go-to-definition?
There was a problem hiding this comment.
Also, it seems the input almost always is a line and column number? If so, that should be the input here as well. So the description would be "Return a definition for the symbol at the given line and column", and if this is too long, we can shorten it.
|
@ankitaS11 Are you launching an |
|
Currently we don't, but we will probably have to add it. |
|
I would probably guess that you need to leave the process running, since more interactive requests like hover will potentially overwhelm the users computer by "spamming" hover requests. |
|
Any news on this? |
I would recommend you hold the merge on this (possibly turn it into a draft) until there is an agreement on the server design. If merged it would be harder to undo in the future. The server should really be a running process with an open communications channel otherwise you are parsing the sources + serving LSP every time you make a request, you should only be doing the latter. For small projects that is probably fine but if this is to be a functional language server it needs to be able to store and query the ASR objects. |
|
More discussion is needed on this, so I converted into a Draft. I didn't have time to push this yet, but I think the design has to be to have a long running LPython/LFortran server process. We had this design, so it is in the history. I think we should revert to it and start improving it. I'll try to get to this soon. |
This PR adds support for
goto-defoption in the compiler, which will be used by VSCode extension. Usage is:In case of errors, or the index not found, it outputs an empty dictionary so that the extension doesn't error out. Otherwise, it outputs a list of valid JSON/dictionary that is parsed in the extension.
PR for the extension depends on this: lcompilers/lpython-vscode-extension#3
cc: @certik