Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LayerSwipe feature #2804

Draft
wants to merge 63 commits into
base: master
Choose a base branch
from
Draft

LayerSwipe feature #2804

wants to merge 63 commits into from

Conversation

taulinger
Copy link
Member

@taulinger taulinger commented Jan 9, 2025

grafik

@taulinger taulinger added the user story Reflects a user story on our board label Jan 9, 2025
@taulinger taulinger changed the title Feature: layer swipe layer swipe feature Jan 9, 2025
@taulinger taulinger changed the title layer swipe feature LayerSwipe feature Jan 10, 2025
@taulinger
Copy link
Member Author

@alsturm

  • activate the compare tool: setCurrentTool(Tools.COMPARE)
  • set the alignment for a layer:
               const leftSide = () => {
			modifyLayer(layer.id, { swipeAlignment: SwipeAlignment.LEFT });
		};
		const bothSide = () => {
			modifyLayer(layer.id, { swipeAlignment: SwipeAlignment.NOT_SET });
		};
		const rightSide = () => {
			modifyLayer(layer.id, { swipeAlignment: SwipeAlignment.RIGHT });
		};

@coveralls
Copy link

coveralls commented Jan 14, 2025

Pull Request Test Coverage Report for Build 12911143707

Details

  • 214 of 214 (100.0%) changed or added relevant lines in 17 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 99.655%

Totals Coverage Status
Change from base Build 12805417855: -0.005%
Covered Lines: 13745
Relevant Lines: 13746

💛 - Coveralls

id="button_remove_all"
.label=${translate(isLayerSwipeActive ? 'layerManager_compare_stop' : 'layerManager_compare')}
.type=${'secondary'}
@click=${toggle}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alsturm Must toggle the tool id!

setCurrentTool(Tools.COMPARE)
setCurrentTool(null)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user story Reflects a user story on our board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants