Update Commit Workflow (#251)

* feat: update commit workflow

- removes husky and refs to it
- adds workflow dispatch
- adds ci runs on pr to main

fix json from changing

remove package json stuff

* feat: split lint and build

.config/dotnet-tools.json

@@ -13,12 +13,6 @@
       "commands": [
         "swagger"
       ]
-    },
-    "husky": {
-      "version": "0.7.0",
-      "commands": [
-        "husky"
-      ]
     }
   }
-}
+}

.github/workflows/lint-backend.yml

@@ -0,0 +1,23 @@
+name: backend-lint
+on:
+    workflow_dispatch:
+    push:
+        branches: [ main ]
+    pull_request:
+        branches: [ main ]
+jobs:
+    backend-test:
+        runs-on: ubuntu-latest
+        steps:
+        - name: Checkout repo
+          uses: actions/checkout@v4
+        - name: Setup dotnet 8
+          uses: actions/setup-dotnet@v4
+          with:
+            dotnet-version: '8.0'
+        - name: Restore NuGet packages
+          run: dotnet restore
+        - name: Restore tools
+          run: dotnet tool restore
+        - name: Lint
+          run: dotnet format --verify-no-changes --no-restore .

.github/workflows/test-backend.yml

@@ -1,10 +1,10 @@
 name: backend-test
 on:
+    workflow_dispatch:
     push:
         branches: [ main ]
     pull_request:
-env:
-  HUSKY: 0
+        branches: [ main ]
 jobs:
     backend-test:
         runs-on: ubuntu-latest
@@ -19,8 +19,6 @@ jobs:
           run: dotnet restore
         - name: Restore tools
           run: dotnet tool restore
-        - name: Lint
-          run: dotnet format --verify-no-changes --no-restore .
         - name: Backup committed openapi.json
           run: cp LeaderboardBackend/openapi.json /tmp/committed-openapi.json
         - name: Build

Dockerfile

@@ -9,7 +9,6 @@ EXPOSE 80
 
 FROM mcr.microsoft.com/dotnet/sdk:8.0 AS build
 ARG DISABLE_OPENAPI_FILE_GEN=true
-ARG HUSKY=0
 
 WORKDIR /source
 # copy csproj and restore as distinct layer that can be cached

LeaderboardBackend/LeaderboardBackend.csproj

@@ -72,11 +72,4 @@
     <Exec Command="dotnet tool restore"></Exec>
     <Exec EnvironmentVariables="EnvPath=../swagger-gen.env;ASPNETCORE_ENVIRONMENT=development" Command="dotnet tool run swagger tofile --output &quot;@(OpenApiFile)&quot; &quot;$(OutputPath)/$(AssemblyName).dll&quot; v1"></Exec>
   </Target>
-
-  <!-- set HUSKY to 0 in CI/CD disable this -->
-  <Target Name="husky" BeforeTargets="Restore;CollectPackageReferences" Condition="'$(HUSKY)' != 0">
-    <Exec Command="dotnet tool restore" StandardOutputImportance="Low" StandardErrorImportance="High" />
-    <Exec Command="dotnet husky install" WorkingDirectory="../" StandardOutputImportance="Low" StandardErrorImportance="High" />
-  </Target>
-
 </Project>

README.md

@@ -16,16 +16,6 @@ The original backend, written in Go and inactive, can be found [here](https://gi
 
 # Project Setup
 
-## Setting up Environment
-
-Firstly, set `core.filemode false` in your git config, either by running `git config core.filemode false` in your terminal, or
-```
-[core]
-    filemode = false
-```
-in your `~/.gitconfig` (Windows users may need to do the latter, according to a comment under [this SO answer](https://stackoverflow.com/a/2972113)). This is to prevent committing filemode changes of our pre-commit hook, `.husky/pre-commit` to your PRs.
-
-
 ## Editor/IDE
 
 There are a couple options available for you to choose, depending on your OS.