Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies & CI, add docs comments, use leancode_lint #4

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Update dependencies & CI, add docs comments, use leancode_lint #4

wants to merge 14 commits into from

Conversation

bartekpacia
Copy link

@bartekpacia bartekpacia commented Nov 29, 2021 •
edited
Loading

fix #3

@bartekpacia bartekpacia force-pushed the chore/use_leancode_lint branch from 009731e to 9008623 Compare November 29, 2021 16:19
@Albert221
Copy link
Member

We need to bump the Dart/Flutter version constraints so that the lints exist.

@bartekpacia bartekpacia force-pushed the chore/use_leancode_lint branch from f8620bb to 241d059 Compare December 1, 2021 11:06
@bartekpacia bartekpacia force-pushed the chore/use_leancode_lint branch from aded953 to 8ce4561 Compare August 15, 2023 14:34
@bartekpacia bartekpacia force-pushed the chore/use_leancode_lint branch from 8ce4561 to aaa2196 Compare August 15, 2023 14:35
@bartekpacia bartekpacia force-pushed the chore/use_leancode_lint branch from a52d9c2 to 948953c Compare August 15, 2023 14:50
@bartekpacia
Copy link
Author

Context: I'm cleaning up my old PRs.

@bartekpacia bartekpacia requested a review from Albert221 August 15, 2023 14:55
@bartekpacia bartekpacia marked this pull request as ready for review August 15, 2023 14:55
@bartekpacia bartekpacia force-pushed the chore/use_leancode_lint branch from e220dec to 2407a51 Compare August 15, 2023 14:56
@bartekpacia bartekpacia force-pushed the chore/use_leancode_lint branch from 2407a51 to b0a0cea Compare August 15, 2023 14:56
@bartekpacia bartekpacia requested review from Albert221 and removed request for Albert221 October 26, 2023 19:38
Albert221
Albert221 reviewed Oct 31, 2023
View reviewed changes
.github/workflows/test.yaml Outdated Show resolved Hide resolved
lib/src/dashed_line_painter.dart Outdated Show resolved Hide resolved
lib/src/dashed_line_painter.dart Outdated Show resolved Hide resolved
@bartekpacia bartekpacia requested a review from Albert221 November 7, 2023 21:38
@bartekpacia bartekpacia changed the title Use leancode lint Update dependencies & CI, add docs comments, use leancode_lint Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Albert221 Albert221 Awaiting requested review from Albert221

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use leancode_lint
2 participants
@bartekpacia @Albert221