feat: List.dropPrefix? / dropSuffix? / dropInfix? and specification lemmas #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 25, 2024
|
Mathlib CI status (docs):
|
Co-authored-by: François G. Dorais <[email protected]>
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 26, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 26, 2024
leanprover-community-bot
added
breaks-mathlib
builds-mathlib
and removed
builds-mathlib
breaks-mathlib
labels
github-actions
bot
removed
the
awaiting-review
eric-wieser
reviewed
Nov 27, 2024
Comment on lines
+1069
to
+1071
| `some r` if `l = p' ++ r` for some `p'` which is paiwise `==` to `p`, | ||
| and `none` otherwise. -/ | ||
| def dropPrefix? [BEq α] : List α → List α → Option (List α) |
There was a problem hiding this comment.
Should this return p' too? Otherwise it seems rather annoying to extract it
eric-wieser
reviewed
Nov 27, 2024
| @@ -15,6 +15,26 @@ namespace List | |||
| @[simp] theorem getElem_mk {xs : List α} {i : Nat} (h : i < xs.length) : | |||
| (Array.mk xs)[i] = xs[i] := rfl | |||
|
|
|||
| /-! ### == -/ | |||
|
|
|||
| @[simp] theorem beq_nil_iff [BEq α] {l : List α} : (l == []) = l.isEmpty := by | |||
There was a problem hiding this comment.
Should this not be beq_nil_eq?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.