Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: uncdot Archive #12421

Closed
wants to merge 1 commit into from
Closed

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Apr 25, 2024

In Archive, these · are scoping when there is a single active goal.

These were found using a modification of the linter at #12339.


Open in Gitpod

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

Clearly, this only un-cdot's. I trust your linter that all these cases are indeed about a single goal only.

@adomani
Copy link
Collaborator Author

adomani commented Apr 25, 2024

I actually did the replacements by hand, to check that the linter was flagging what I thought it should!

@grunweg
Copy link
Collaborator

grunweg commented May 21, 2024

I still think this is a good change; let's get this in rather than letting this rot.
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@mattrobball
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels May 21, 2024
mathlib-bors bot pushed a commit that referenced this pull request May 21, 2024
In `Archive`, these `·` are scoping when there is a single active goal.

These were found using a modification of the linter at #12339.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented May 21, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: uncdot Archive [Merged by Bors] - chore: uncdot Archive May 21, 2024
@mathlib-bors mathlib-bors bot closed this May 21, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/uncdot_libs branch May 21, 2024 21:37
callesonne pushed a commit that referenced this pull request Jun 4, 2024
In `Archive`, these `·` are scoping when there is a single active goal.

These were found using a modification of the linter at #12339.
js2357 pushed a commit that referenced this pull request Jun 18, 2024
In `Archive`, these `·` are scoping when there is a single active goal.

These were found using a modification of the linter at #12339.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants