Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate Setoid.Rel #16260

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

chore: deprecate Setoid.Rel #16260

wants to merge 8 commits into from
+111 −106

Conversation

FR-vdash-bot
Copy link
Collaborator

@FR-vdash-bot FR-vdash-bot commented Aug 29, 2024 •
edited by github-actions bot
Loading

@FR-vdash-bot FR-vdash-bot added the t-data Data (lists, quotients, numbers, etc) label Aug 29, 2024
@FR-vdash-bot FR-vdash-bot mentioned this pull request Aug 29, 2024
Draft
12 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

PR summary 3275fc5fed

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ext'_iff
- ext_iff
--++ stabilizerEquivStabilizerOfOrbitRel

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Aug 29, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 2, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 9, 2024
@mathlib4-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 9, 2024
urkud
urkud reviewed Oct 9, 2024
View reviewed changes
Mathlib/Data/Setoid/Basic.lean
Iff.rfl

@[refl]
theorem refl' (r : Setoid α) (x) : r.Rel x x := r.iseqv.refl x
theorem refl' (r : Setoid α) (x) : r x x := r.iseqv.refl x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it differ from Setoid.refl now? Same below.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Setoid.refl Setoid.symm Setoid.trans is in the core and uses instance parameters and (· ≈ ·).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

Assignees
No one assigned
Labels
t-data Data (lists, quotients, numbers, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FR-vdash-bot @mathlib4-dependent-issues-bot @urkud @leanprover-community-bot-assistant @leanprover-community-mathlib4-bot