Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(Topology/KrullDimension): add invariance under homeomorphism theorem and auxiliary lemmas #17175

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat(Topology/KrullDimension): add invariance under homeomorphism theorem and auxiliary lemmas #17175

wants to merge 6 commits into from

Conversation

Raph-DG
Copy link
Collaborator

@Raph-DG Raph-DG commented Sep 26, 2024

Added some lemmas about the topological Krull dimension

Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community! label Sep 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

PR summary 60ac3c0c39

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ClosedEmbedding.topologicalKrullDim_le
+ Injective.image_strictMono
+ IrreducibleCloseds.map
+ IrreducibleCloseds.map_strictMono
+ IsHomeomorph.topologicalKrullDim_eq

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@joneugster joneugster added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Sep 27, 2024
@joneugster joneugster changed the title Added some lemmas about the topological Krull dimension (main result being Krull dimension invariant under homeomorphisms) feat(Topology/KrullDimension): add invariance under homeomorphism theorem and auxiliary lemmas Sep 27, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 28, 2024
jcommelin
jcommelin approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by jcommelin.

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 30, 2024
riccardobrasca
riccardobrasca approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/Data/Set/Image.lean Outdated
@@ -1090,6 +1090,10 @@ theorem Injective.image_injective (hf : Injective f) : Injective (image f) := by
intro s t h
rw [← preimage_image_eq s hf, ← preimage_image_eq t hf, h]

lemma Injective.image_strictMono {X Y : Type*}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there is an f already in scope here.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Sep 30, 2024

✌️ Raph-DG can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Raph-DG
Copy link
Collaborator Author

Raph-DG commented Oct 1, 2024

Thanks for the reviews!

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Oct 1, 2024
@Raph-DG
feat(Topology/KrullDimension): add invariance under homeomorphism the…
0d57a34 
…orem and auxiliary lemmas (#17175)

Added some lemmas about the topological Krull dimension
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/KrullDimension): add invariance under homeomorphism theorem and auxiliary lemmas [Merged by Bors] - feat(Topology/KrullDimension): add invariance under homeomorphism theorem and auxiliary lemmas Oct 1, 2024
@mathlib-bors mathlib-bors bot closed this Oct 1, 2024
@mathlib-bors mathlib-bors bot deleted the Raph-DG-TopologicalKrull branch October 1, 2024 18:06
fbarroero pushed a commit that referenced this pull request Oct 2, 2024
@Raph-DG @fbarroero
feat(Topology/KrullDimension): add invariance under homeomorphism the…
f799d74 
…orem and auxiliary lemmas (#17175)

Added some lemmas about the topological Krull dimension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@riccardobrasca riccardobrasca riccardobrasca approved these changes

Assignees
No one assigned
Labels
delegated maintainer-merge new-contributor This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community! t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Raph-DG @jcommelin @riccardobrasca @joneugster @leanprover-community-bot-assistant @leanprover-community-mathlib4-bot