Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: remove some unused variables #17261

Closed
wants to merge 6 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Sep 29, 2024

Inspired by #17178 and found by a linter.


Open in Gitpod

Copy link

github-actions bot commented Sep 29, 2024

PR summary f70dfcdec4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@kim-em
Copy link
Contributor

kim-em commented Sep 29, 2024

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Sep 29, 2024

✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@adomani
Copy link
Collaborator Author

adomani commented Sep 30, 2024

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit f70dfcd.
There were no significant changes against commit 5a3902a.

@adomani
Copy link
Collaborator Author

adomani commented Sep 30, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Sep 30, 2024
Inspired by #17178 and found by a linter.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Sep 30, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove some unused variables [Merged by Bors] - chore: remove some unused variables Sep 30, 2024
@mathlib-bors mathlib-bors bot closed this Sep 30, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/unused_variable_removals branch September 30, 2024 01:16
@@ -167,7 +167,7 @@ end DivisionRing

section Semifield

variable [Semifield K] {a b c d : K}
variable [Semifield K] {a b d : K}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This strikes me as maybe not a useful change 😁

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point, but you can see that c and d alternate being implicit/explicit/non-present in the following lemmas and I do not think that d is ever used before c!

chrisflav pushed a commit that referenced this pull request Oct 1, 2024
Inspired by #17178 and found by a linter.
fbarroero pushed a commit that referenced this pull request Oct 2, 2024
Inspired by #17178 and found by a linter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants