Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Measure/WithDensityFinite): redefine Measure.toFinite #17421

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 4, 2024

  • Redefine Measure.toFinite using exists_isFiniteMeasure_absolutelyContinuous.
  • Redefine Measure.densityToFinite as rnDeriv, deprecate it.
  • Drop some lemmas about toFiniteAux.
  • Simplify proofs.

Open in Gitpod

@urkud urkud added the t-measure-probability Measure theory / Probability theory label Oct 4, 2024
@urkud urkud requested a review from RemyDegenne October 4, 2024 17:02
Copy link

github-actions bot commented Oct 4, 2024

PR summary db8a216269

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ae_toFinite
+ ae_toFiniteAux
+ instance [SFinite μ] [NeZero μ] : IsProbabilityMeasure μ.toFinite := by
+ isFiniteMeasure_toFiniteAux
+ sFiniteSeq_le
+ toFinite_apply_eq_zero_iff
+ toFinite_eq_self
- instance [SFinite μ] : IsFiniteMeasure μ.toFiniteAux
- instance [SFinite μ] [h_zero : NeZero μ] : IsProbabilityMeasure μ.toFinite := by
- sFiniteSeq_absolutelyContinuous_toFiniteAux
- toFiniteAux_absolutelyContinuous_toFinite
- toFiniteAux_apply
- toFiniteAux_eq_zero_iff
- toFiniteAux_univ_le_one
- toFiniteAux_zero
- toFinite_apply

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@RemyDegenne
Copy link
Contributor

Please update the file docstring to reflect the changes.

@RemyDegenne RemyDegenne added the awaiting-author A reviewer has asked the author a question or requested changes label Oct 5, 2024
@urkud urkud removed the awaiting-author A reviewer has asked the author a question or requested changes label Oct 9, 2024
@urkud
Copy link
Member Author

urkud commented Oct 9, 2024

@RemyDegenne I updated docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-measure-probability Measure theory / Probability theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants