Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Fintype instance for an extended family of linearly independent vectors #17541

Closed
wants to merge 2 commits into from

Conversation

EtienneC30
Copy link
Collaborator

Given a family of linearly independent vectors $s \subset t$, one can get a linearly independent family which spans the submodule spanned by $t$ containing $s$. We add a Fintype instance for this family in the case where the span of $t$ is finite so as to be able to write sums over this type when manipulating bases indexed by it (typically Basis.extend and similar).


Open in Gitpod

@EtienneC30 EtienneC30 added the t-algebra Algebra (groups, rings, fields, etc) label Oct 8, 2024
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

PR summary 4ad9126799

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ LinearIndependent.span_extend_eq_span
+ instance {R M : Type*} [DivisionRing R] [AddCommGroup M] [Module R M]

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@sgouezel
Copy link
Contributor

sgouezel commented Oct 8, 2024

Can you find a better place for your instance? Here, it's adding a lot of imports to the file Mathlib.LinearAlgebra.Basis.VectorSpace, as you can see from the github-action comment above, which should probably be avoided.

@sgouezel sgouezel added the awaiting-author A reviewer has asked the author a question or requested changes label Oct 8, 2024
@github-actions github-actions bot removed the large-import Automatically added label for PRs with a significant increase in transitive imports label Oct 8, 2024
@EtienneC30 EtienneC30 removed the awaiting-author A reviewer has asked the author a question or requested changes label Oct 8, 2024
@sgouezel
Copy link
Contributor

sgouezel commented Oct 9, 2024

bors r+
Thanks!

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 9, 2024
…nt vectors (#17541)

Given a family of linearly independent vectors $s \subset t$, one can get a linearly independent family which spans the submodule spanned by $t$ containing $s$. We add a `Fintype` instance for this family in the case where the span of $t$ is finite so as to be able to write sums over this type when manipulating bases indexed by it (typically `Basis.extend` and similar).
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Fintype instance for an extended family of linearly independent vectors [Merged by Bors] - feat: Fintype instance for an extended family of linearly independent vectors Oct 9, 2024
@mathlib-bors mathlib-bors bot closed this Oct 9, 2024
@mathlib-bors mathlib-bors bot deleted the em/fintype_extend branch October 9, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants