Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Tactic/Linter/Style): check declIDs #17580

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Oct 9, 2024


Open in Gitpod

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

PR summary c96272ea16

Import changes exceeding 2%

% File
+100.00% Mathlib.Tactic.Linter.Style

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Tactic.Linter.Style 1 2 +1 (+100.00%)
Mathlib.ModelTheory.PartialEquiv 1034 1035 +1 (+0.10%)
Import changes for all files
Files Import difference
There are 4860 files with changed transitive imports taking up over 199446 characters: this is too many to display!
You can run scripts/import_trans_difference.sh all locally to see the whole output.

Declarations diff

+ checkDeclIDLinter:
+ contains_double_underscore
+ double__underscore
+ getNames
+ toEmbeddingOfEqTop_apply

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@github-actions github-actions bot added the t-linter Linter label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large-import Automatically added label for PRs with a significant increase in transitive imports t-linter Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant