Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sym2-as-Finset theory #17587

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

feat: Sym2-as-Finset theory #17587

wants to merge 5 commits into from

Conversation

kmill
Copy link
Contributor

@kmill kmill commented Oct 9, 2024


Open in Gitpod

Copy link

github-actions bot commented Oct 9, 2024

PR summary 8c08565c6e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ card
+ card_toFinset_mk_of_ne
+ card_toFinset_of_isDiag
+ card_toFinset_of_not_isDiag
+ coe_toFinset
+ edge_toFinset_card
+ isDiag_iff_exists
+ mem_toFinset
+ setOf_mem_eq
+ toFinset

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Oct 9, 2024
@FordUniver
Copy link
Collaborator

I just noticed that there is both the file Mathlib.Data.Sym.Sym2.lean and the folder Mathlib.Data.Sym.Sym2. Is this intended or should the contents of Sym2.lean eventualy migrate into the folder?

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community! label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-contributor This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community! t-data Data (lists, quotients, numbers, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants