Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add vscode cmake configuration #3008

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

eric-wieser
Copy link
Contributor

@eric-wieser eric-wieser commented Dec 1, 2023

This sets the build directory to build/release for the "CMake Tools for Visual Studio Code" extension documented at https://vector-of-bool.github.io/docs/vscode-cmake-tools/settings.html#cmake-builddirectory.

It also sets the generator to make, since otherwise it tries Ninja which doesn't work.

Without these settings, the extension runs configure in a bad place at startup.

This does not add the cmake tools extension to the default workspace configuration; the goal is simply to prevent bad behavior for users who already have the extension enabled.

Summary

Screenshot of this in action:

image

Link to RFC or bug issue: N/A, this is not a bug nor a user-visible feature.

This sets the build directory to `build/release` for the extension documented at https://vector-of-bool.github.io/docs/vscode-cmake-tools/settings.html#cmake-builddirectory.

It also sets the generator to `make`, since otherwise it tries `Ninja` which doesn't work.
@eric-wieser eric-wieser changed the title dev: add vscode cmake configuration chore: add vscode cmake configuration Dec 1, 2023
@eric-wieser
Copy link
Contributor Author

awaiting-review

@github-actions github-actions bot added awaiting-review Waiting for someone to review the PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN labels Dec 1, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

  • ❗ Mathlib CI will not be attempted unless you rebase your PR onto the 'nightly' branch. (2023-12-01 18:16:50)

@Kha Kha added this pull request to the merge queue Dec 4, 2023
Merged via the queue into leanprover:master with commit 93a6279 Dec 4, 2023
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review Waiting for someone to review the PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants