feat: synchronous execution of task continuations #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 2, 2023
leanprover-community-mathlib4-bot
added
the
builds-mathlib
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 2, 2023
joehendrix
approved these changes
Dec 5, 2023
|
Just to mention design alternatives I've considered, one could ask whether we should use a forward-compatible flag enum instead like .NET does above. But that's not something we really have as an idiom so far. In any case, I think this feature is advanced enough that I would not expect too much downstream breakage if we do consider a refactoring the next time we add a parameter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new snapshot design, we have a tree of
Tasks that represents the asynchronously processed document structure. When transforming this tree in response to a user edit, we want to quickly run through reusable, already computed nodes of the tree synchronously and then spawn new tasks for the new parts. The new flag allows us to do such mixed sync/async tree transformations uniformly. This flag exists as e.g.ExecuteSynchronouslyin other runtimes.