refactor: WF.Fix: gather subgoals #3017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is pure refactoring: Instead of solving each subgoal as we encounter it while traversing the syntax tree, we leave the `MVar` there, at the end collect them all using `getMVarsNoDelayed`, and then solve them. This is a refactoring preparing for two upcoming changes: * removing unexpected duplicate goals that can arise from term duplication * running interactive tactics on all, not each goal (#2921) In order to not regress with error locations, we have to associated the `TermElabM`’s syntax refernce with the `MVar` somehow. I do this using the existing `mkRecAppWithSyntax` expression annotation, on the `MVar`’s type. Alternatives would be stack another `StateT` on the traversal and accumulate `Array (MVarId, Syntax)` explicitly, but that did not seem to be more appealing.
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 4, 2023
leanprover-community-mathlib4-bot
added
the
builds-mathlib
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 4, 2023
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 4, 2023
nomeata
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pure refactoring: Instead of solving each subgoal as we
encounter it while traversing the syntax tree, we leave the
MVarthere, at the end collect them all using
getMVarsNoDelayed, and thensolve them.
This is a refactoring preparing for two upcoming changes:
duplication
In order to not regress with error locations, we have to associated the
TermElabM’s syntax refernce with theMVarsomehow. I do this usingthe existing
mkRecAppWithSyntaxexpression annotation, on theMVar’stype. Alternatives would be stack another
StateTon the traversaland accumulate
Array (MVarId, Syntax)explicitly, but that did notseem to be more appealing.