Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor pr release workflow #3020

Merged
merged 18 commits into from
Dec 12, 2023
Merged

chore: refactor pr release workflow #3020

merged 18 commits into from
Dec 12, 2023

Conversation

nomeata
Copy link
Contributor

@nomeata nomeata commented Dec 4, 2023

In particular:

  • Do not use deprecated potiuk/get-workflow-origin.
  • Use a bare checkout to push PR to pr-releases
  • Replace script/most-recent-nightly-tag.sh by a one-liner inside the workflow, so that th workflow is self-contained

@nomeata
Copy link
Contributor Author

nomeata commented Dec 4, 2023

I did some testing over at https://github.com/nomeata/lean4/actions/workflows/pr-release.yml and it may actually work.

The cloning and pushing is awfully slow, thought.

Hmm, a bit work needed with the git merge-base.

@nomeata nomeata marked this pull request as draft December 4, 2023 19:59
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 4, 2023
@nomeata
Copy link
Contributor Author

nomeata commented Dec 4, 2023

I maybe have weeded out all the bugs. Quite tedious, writing and testing such actions. But better double check, or test, or be prepared to use admin rights to revert quickly if it doesn’t work after all.

BTW, can someone delete the tag nightly-2023-11-20 in the lean4 repo? Looks like it was pushed to the wrong repo.

@nomeata nomeata marked this pull request as ready for review December 4, 2023 20:50
@Kha
Copy link
Member

Kha commented Dec 4, 2023

BTW, can someone delete the tag nightly-2023-11-20 in the lean4 repo? Looks like it was pushed to the wrong repo.

Done, thanks

@nomeata
Copy link
Contributor Author

nomeata commented Dec 4, 2023

https://github.com/nomeata/lean4/actions/runs/7092668924/job/19304449256 ran through till the mathlib steps which I did not touch. So might work :-)

@nomeata
Copy link
Contributor Author

nomeata commented Dec 4, 2023

I just learned about --filter=tree:0 for a treeless clone: https://github.blog/2020-12-21-get-up-to-speed-with-partial-clone-and-shallow-clone/

I wonder if this will speed up the job noticably.

@nomeata
Copy link
Contributor Author

nomeata commented Dec 5, 2023

I just learned about --filter=tree:0 for a treeless clone: https://github.blog/2020-12-21-get-up-to-speed-with-partial-clone-and-shallow-clone/

I wonder if this will speed up the job noticably.

Just tried locally. Cloning treeless is super fast, and one can calculate the merge base this way, but then pushing to the other repo is super slow; it seems that git is downloading the missing trees and blobs that it wants to push one by one.

So maybe let's keep it as it is for now.

Copy link
Collaborator

@kim-em kim-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

(I'm going to be flying back to Australia over the weekend; perhaps we can merge this on Monday so I'll be available in case anything unexpected happens.)

@nomeata
Copy link
Contributor Author

nomeata commented Dec 8, 2023

Sounds good! I'll let you merge it when it suits you

@kim-em kim-em added this pull request to the merge queue Dec 12, 2023
Merged via the queue into master with commit fa26d22 Dec 12, 2023
7 checks passed
@nomeata nomeata deleted the joachim/simpler-pr-release branch December 12, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants