-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor pr release workflow #3020
Conversation
it’s now a one-liner in the workflow
I did some testing over at https://github.com/nomeata/lean4/actions/workflows/pr-release.yml and it may actually work. The cloning and pushing is awfully slow, thought. Hmm, a bit work needed with the |
I maybe have weeded out all the bugs. Quite tedious, writing and testing such actions. But better double check, or test, or be prepared to use admin rights to revert quickly if it doesn’t work after all. BTW, can someone delete the tag |
Done, thanks |
https://github.com/nomeata/lean4/actions/runs/7092668924/job/19304449256 ran through till the mathlib steps which I did not touch. So might work :-) |
I just learned about I wonder if this will speed up the job noticably. |
Just tried locally. Cloning treeless is super fast, and one can calculate the merge base this way, but then pushing to the other repo is super slow; it seems that git is downloading the missing trees and blobs that it wants to push one by one. So maybe let's keep it as it is for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
(I'm going to be flying back to Australia over the weekend; perhaps we can merge this on Monday so I'll be available in case anything unexpected happens.)
Sounds good! I'll let you merge it when it suits you |
In particular:
potiuk/get-workflow-origin
.pr-releases
script/most-recent-nightly-tag.sh
by a one-liner inside the workflow, so that th workflow is self-contained