-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upstream congr!
from Mathlib
#3673
Conversation
Mathlib CI status (docs):
|
Oh wow, I wasn't expecting to see that By the way, I have an open PR to add that LawfulBEq instances are equal: leanprover-community/mathlib4#11179 |
@kmill, I don't think it is super urgent, so if you think there is good reason to delay moving it to allow for a refactor, I think we can do that. I'm happy with moving it as is and updating later, however. |
I don't have any good reason to delay merging it, and I'm not sure when I'd get around to refactoring it, so carrying on with upstreaming seems fine to me. (Thanks!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any hope that we can have a single congr
tactic in lean, so that users don't have to learn about the difference? What would happen if this congr!
were the only one?
Ah, I see in the comments above that this is the plan, or at least the hope.
We decided not to proceed at this point. @kmill is refactoring the Mathlib implementation in the meantime. |
This is a preliminary step to upstreaming
convert
.We should later think about combining this with the standard
congr
.There is still a builtin problem here, that you can not use
congr! (config := ...)
withoutimport Lean.Meta.Tactic.Congr!
. We need to move the config structure into e.g.Init/MetaTypes.lean
, and then an update-stage0, but I haven't got it to work.This is stacked on top of #3671 and #3672, and I'll wait for those to merge.