Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: variable must execute pending tactics and elaboration problems #4370

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

leodemoura
Copy link
Member

closes #2226
closes #3214

@leodemoura
Copy link
Member Author

leodemoura commented Jun 6, 2024

@semorrison This PR may affect Mathlib. If there are too many issues, we should just skip this PR and fix the issues above when we address RFC #2452

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc June 6, 2024 01:31 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 6, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 6, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 6, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan release-ci Enable all CI checks for a PR, like is done for releases labels Jun 6, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Jun 6, 2024

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 6, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 6, 2024
@kim-em
Copy link
Collaborator

kim-em commented Jun 6, 2024

@leodemoura, the fallout in Mathlib is manageable. The only change is that we can no longer change the explicitness of a variable, and in the same line introduce a new variable that depends on it.

(I'm not sure if that is an intended or avoidable effect of this PR!)

@kim-em
Copy link
Collaborator

kim-em commented Jun 6, 2024

Mathlib should build now. Diff is at leanprover-community/mathlib4@026f1b9 for reference.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Jun 6, 2024
@eric-wieser
Copy link
Contributor

The only change is that we can no longer change the explicitness of a variable, and in the same line introduce a new variable that depends on it.

This was often a footgun in mathlib anyway, as sometimes it resulted in duplicate hypotheses.

@leodemoura leodemoura added this pull request to the merge queue Jun 6, 2024
@leodemoura
Copy link
Member Author

The only change is that we can no longer change the explicitness of a variable, and in the same line introduce a new variable that depends on it.

This was often a footgun in mathlib anyway, as sometimes it resulted in duplicate hypotheses.

Thanks for feedback. So, I will go ahead and merge the PR.

Merged via the queue into master with commit 0a0f1d7 Jun 6, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#synth silently succeeds if given nonsense def fails without error (by in variable)
4 participants