Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adapt kernel interruption to new cancellation system #4584

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

Kha
Copy link
Member

@Kha Kha commented Jun 28, 2024

Kernel checks were not canceled on edit after #3014

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 28, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 28, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 28, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jun 28, 2024
@Kha Kha marked this pull request as ready for review July 1, 2024 14:52
@Kha Kha requested a review from leodemoura as a code owner July 1, 2024 14:52
@Kha Kha added this pull request to the merge queue Jul 1, 2024
Merged via the queue into leanprover:master with commit 7f00767 Jul 1, 2024
17 checks passed
Copy link
Contributor

github-actions bot commented Jul 1, 2024

The backport to releases/v4.9.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-releases/v4.9.0 releases/v4.9.0
# Navigate to the new working tree
cd .worktrees/backport-releases/v4.9.0
# Create a new branch
git switch --create backport-4584-to-releases/v4.9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7f00767b1e123f550d06a0e740bfd4e663b5c6bf
# Push it to GitHub
git push --set-upstream origin backport-4584-to-releases/v4.9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-releases/v4.9.0

Then, create a pull request where the base branch is releases/v4.9.0 and the compare/head branch is backport-4584-to-releases/v4.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport releases/v4.9.0 builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants