Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inaccessible pattern vars reported as binders #5337

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix: inaccessible pattern vars reported as binders #5337

merged 1 commit into from
Sep 13, 2024

Conversation

Kha
Copy link
Member

@Kha Kha commented Sep 13, 2024 •
edited
Loading

Fixes an unused variable false positive on some wildcard patterns

Fixes #1633, fixes #2830

Kha
Kha commented Sep 13, 2024
View reviewed changes
Copy link
Member Author

@Kha Kha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(stacked on #5335 to avoid test merge conflict)

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 13, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 13, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5337
ba11838
@Kha Kha enabled auto-merge September 13, 2024 09:42
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 13, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5337
d0d61ce
@Kha Kha added this pull request to the merge queue Sep 13, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 13, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5337
0a96ef8
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 13, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5337
49e3767
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

Merged via the queue into leanprover:master with commit 438061a Sep 13, 2024
14 checks passed
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Sep 13, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

tobiasgrosser pushed a commit to opencompl/lean4 that referenced this pull request Sep 16, 2024
@Kha @tobiasgrosser
fix: inaccessible pattern vars reported as binders (leanprover#5337)
ab9233e 
Fixes an unused variable false positive on some wildcard patterns

Fixes leanprover#1633, fixes leanprover#2830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spurious linter warning "unused variable" linter.unusedVariables false positive
2 participants
@Kha @leanprover-community-bot