fix: automatic instance names about types with hygienic names should be hygienic #5530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be hygienic Macros sometimes create auxiliary types and instances about them, and they rely on the instance name generate to create unique names in that case. This modifies the automatic name generator to add a fresh macro scope to the generated name if any of the constants in the type of the instance themselves have macro scopes. Closes leanprover#2044
|
@Kha What do you think about having the auto-generated instance names use a fresh macro scope if any of the constants in the type of the instance themselves have macro scopes? There's a chance this is too conservative, in case somehow there are instances with macro scopes for example, but I was afraid of not being conservative enough. It's still using the name generator for debuggability, if you need to poke around the macro expansions. |
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 30, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 30, 2024
leanprover-community-bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
Kha
reviewed
Sep 30, 2024
Kha
approved these changes
Sep 30, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macros sometimes create auxiliary types and instances about them, and they rely on the instance name generate to create unique names in that case.
This modifies the automatic name generator to add a fresh macro scope to the generated name if any of the constants in the type of the instance themselves have macro scopes.
Closes #2044