Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add MonadLift Id m instance #5638

Closed
wants to merge 2 commits into from
Closed

feat: add MonadLift Id m instance #5638

wants to merge 2 commits into from

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Oct 7, 2024

No description provided.

@kmill kmill added the awaiting-review Waiting for someone to review the PR label Oct 7, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 7, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 7, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5638
6e1d3e1
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 7, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5638
9615297
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Oct 7, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 7, 2024 •
edited
Loading

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 7, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5638
3d45cda
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 7, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5638
82f6f02
@kmill
Copy link
Collaborator Author

kmill commented Oct 8, 2024

Closing. I don't have a pressing need for this, and it's easy enough to lift Id monads using Id.run, which is very rare to need to do.

The original motivation was in some automation in #eval where it was easier to make all values monadic, even pure ones, and then use MonadLift to bring all values into a common monad. The design changed, and this instance is no longer necessary.

@kmill kmill closed this Oct 8, 2024
@kmill
Copy link
Collaborator Author

kmill commented Oct 8, 2024

(Note: closed after discussion with @Kha)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting-review Waiting for someone to review the PR builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmill @leanprover-community-bot