Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: define udiv normal form to be /, resp. umod and % #5645

Merged
merged 2 commits into from
Oct 8, 2024
Merged

chore: define udiv normal form to be /, resp. umod and % #5645

merged 2 commits into from
Oct 8, 2024

Conversation

bollu
Copy link
Contributor

@bollu bollu commented Oct 8, 2024

This follows the norm for all other Bitvector operations, and makes the symbols / and % the simp normal form.

I'd imagine that @hargoniX would prefer that this be merged after #5628, so as to prevent churn for his PR. I'm happy to rebase the PR once the other PR lands.

@bollu bollu changed the title chore: define udiv normal form to be /, resp. umod and %. chore: define udiv normal form to be /, resp. umod and % Oct 8, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 8, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 8, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d8356165739895b577fa10f7db9517c4e02d801a --onto 9dac514c2fc80d3f60076314ad30a993a7b2c22f. (2024-10-08 01:40:49)
  • ❗ Batteries CI can not be attempted yet, as the nightly-testing-2024-10-08 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Batteries CI should run now. (2024-10-08 08:44:20)

@bollu bollu mentioned this pull request Oct 8, 2024
Merged
@hargoniX hargoniX added this pull request to the merge queue Oct 8, 2024
@hargoniX hargoniX removed this pull request from the merge queue due to a manual request Oct 8, 2024
@hargoniX hargoniX added this pull request to the merge queue Oct 8, 2024
@hargoniX hargoniX removed this pull request from the merge queue due to a manual request Oct 8, 2024
bollu and others added 2 commits October 8, 2024 09:22
@bollu @hargoniX
chore: define udiv normal form to be %, resp. umod and %.
f1b996e 
This follows the norm for all other Bitvector operations,
and makes the symbolic version the simp normal form.

I would imagine that @hargoniX would prefer that this be merged
after leanprover#5628,
so as to prevent churn for his PR.
I'm happy to rebase the PR.
@hargoniX
fix rebased changes
5e958f5
@hargoniX hargoniX added this pull request to the merge queue Oct 8, 2024
Merged via the queue into leanprover:master with commit 2ed7924 Oct 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasgrosser tobiasgrosser tobiasgrosser approved these changes

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bollu @leanprover-community-bot @tobiasgrosser @hargoniX