fix: store local context for 'don't know how to synthesize implicit argument' errors #5658
+29
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgument' errors When named arguments introduce eta arguments, the full application contains fvars for these eta arguments, so `MVarErrorKind.implicitArg` needs to keep a local context for its error messages. The local context of the mvar associated to the `MVarErrorKind` is not sufficient since when an eta argument come after an implicit argument, the implicit argument's mvar doesn't contain the eta argument's fvar in its local context. Closes leanprover#5475
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When named arguments introduce eta arguments, the full application contains fvars for these eta arguments, so
MVarErrorKind.implicitArgneeds to keep a local context for its error messages. This is because the local context of the mvar associated to theMVarErrorKindis not sufficient, since when an eta argument come after an implicit argument, the implicit argument's mvar doesn't contain the eta argument's fvar in its local context.Closes #5475