Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eNATL Pyramid recipe #10

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

eNATL Pyramid recipe #10

wants to merge 17 commits into from

Conversation

norlandrhagen
Copy link
Contributor

No description provided.

Copy link
Contributor

@jbusecke jbusecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @norlandrhagen! Should i give this a go? The version in #9 still has some bugs, but I suspect these dont block here?

feedstock/pyramid.py Outdated Show resolved Hide resolved
feedstock/meta.yaml Show resolved Hide resolved
@norlandrhagen
Copy link
Contributor Author

@jbusecke yeah, I think it would be worth a shot running it. It'll be pulling off that 31 day Zarr store, but that'll be a nice test.

@jbusecke
Copy link
Contributor

jbusecke commented Aug 8, 2024

Ah this is failing due to the recipe id naming. See #9 (comment) for a fix (basically just using dashes instead of underscores). Can you maybe rebase this PR onto #9 to keep things compatible?

Also on a side note, this naming thing is really frigging annoying, and maybe we should push harder upstream. Maybe we should just submit a PR there?

@norlandrhagen
Copy link
Contributor Author

I was running into: TypeError: unsupported operand type(s) for /: 'RequiredAtRuntimeDefault' and 'str' in StoreToPyramid. I drafted a new pangeo-forge-recipes release to include the updated injection specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants