chore: rework Period object constructor #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Set `usePrev` by default. BREAKING change 2. Accept optional third arguments of `PeriodOptions` type: allows to set validator data and set `usePrev` to false for legacy proofs.
troggy
added a commit
that referenced
this pull request
Dec 23, 2019
* Add previous period to proofs and roots if present. * Add ability to produce and verify prevPeriod proofs. Also fix tests and fix backwards compatibility issue. * chore: rework Period object constructor (#167) * chore: rework Period object constructor 1. Set `usePrev` by default. BREAKING change 2. Accept optional third arguments of `PeriodOptions` type: allows to set validator data and set `usePrev` to false for legacy proofs. * docs: add period hashing schema * PrevPeriod proof verification clarification Co-authored-by: Kosta Korenkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion for #166
usePrevby default. BREAKING changePeriodOptionstype:allows to set validator data and set
usePrevto false for legacy proofs.