Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solver service #159

Merged
merged 26 commits into from
Aug 8, 2019
Merged

Solver service #159

merged 26 commits into from
Aug 8, 2019

Conversation

sunify
Copy link
Member

@sunify sunify commented Jul 30, 2019

Based on ExecutionPoker

Resolves #116

@codecov-io
Copy link

codecov-io commented Jul 30, 2019

Codecov Report

Merging #159 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files          13       13           
  Lines        1451     1451           
=======================================
  Hits         1359     1359           
  Misses         92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a02e5...a23006b. Read the comment docs.

challenger/solEVM/LOG Outdated Show resolved Hide resolved
@sunify sunify marked this pull request as ready for review August 6, 2019 17:06
@sunify sunify changed the title Solver/challenger Solver service Aug 6, 2019
package.json Outdated Show resolved Hide resolved
constructor (db, ...args) {
super(...args);
this.db = db;
// this.restoreSolutions();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't use storage, we can delete that part?
Though, what about storing the block height of the last processed event and storing that?

We can use that to replay events from that last known height on restart 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on removing. Replay sounds like a good idea, but not really sure if it should be in the scope of this bounty. Up to @johannbarbie

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of scope, but nice to have. if some-one cares to garden it, plz do

Copy link
Contributor

@pinkiebell pinkiebell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some question :)

Copy link
Contributor

@pinkiebell pinkiebell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍦🍯😋

yarn.lock has a merge conflict, once this is resolved we can merge it

@pinkiebell pinkiebell merged commit f4c49af into master Aug 8, 2019
@pinkiebell pinkiebell deleted the challenger branch August 8, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create a solver/challenger service based on off-chain interpreter
4 participants