-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Static Site With Built Components #35
Open
ASPhillips8
wants to merge
5
commits into
learn-co-curriculum:master
Choose a base branch
from
ASPhillips8:components-mini-project-asp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cf84023
Create Header Component
ASPhillips8 3bcc963
Create About Component
ASPhillips8 d372c64
Destructure prop in Header Component
ASPhillips8 f266fa0
Create file for Article and ArticleList Components
ASPhillips8 ec1e981
Create Aricle and ArticleList Components
ASPhillips8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import React from "react"; | ||
|
||
const imageDefault = "https://via.placeholder.com/215" | ||
|
||
function About ({image = imageDefault, about}){ | ||
return ( | ||
<aside> | ||
<img src={image} alt="blog logo"></img> | ||
<p>{about}</p> | ||
</aside> | ||
) | ||
} | ||
|
||
export default About |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import React from "react"; | ||
|
||
function Article ({title, date = "January 1, 1970", preview}) { | ||
return ( | ||
<article> | ||
<h3>{title}</h3> | ||
<small>{date}</small> | ||
<p>{preview}</p> | ||
</article> | ||
) | ||
} | ||
|
||
export default Article |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import React from "react"; | ||
import Article from "./Article"; | ||
|
||
function ArticleList ({posts}) { | ||
console.log(posts) | ||
const articles = posts.map((post) => { | ||
return ( | ||
<Article | ||
key={post.id} | ||
title={post.title} | ||
preview={post.preview} | ||
date={post.date} | ||
/> | ||
) | ||
}) | ||
|
||
return ( | ||
<main>{articles}</main> | ||
) | ||
} | ||
|
||
export default ArticleList |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import React from "react"; | ||
|
||
function Header ({name}) { | ||
return ( | ||
<header> | ||
<h1>{name}</h1> | ||
</header> | ||
) | ||
} | ||
|
||
export default Header |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.