Get the country of each session #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaulLu
commented
Dec 7, 2021
Comment on lines
+49
to
+56
| try: | ||
| response = urllib.request.urlopen(URL_IP_INFO) | ||
| data = json.load(response) | ||
| country = data["country"] | ||
| except Exception: | ||
| country = "" | ||
| return country | ||
|
|
There was a problem hiding this comment.
I know that bare except is not a good practice, nevertheless I thought here that it was useless to risk to have an error at this level for this information which is only a "nice to have"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously discussed, this PR comes shortly before the deadline: I leave you the choice to integrate it or not.
For your information, I tested to modify a trainer in a similar way by modifying the demo notebook of the HF trainer to check these changes. You can check it here.