To add bandwidth metrics #35
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metrics to hivemind
justheuristic
requested changes
Nov 28, 2023
pb/Makefile
Outdated
| @@ -4,3 +4,11 @@ all: $(pbgos) | |||
|
|
|||
| %.pb.go: %.proto | |||
| protoc --gogofast_out=. --proto_path=$(GOPATH)/src:. $< | |||
|
|
|||
There was a problem hiding this comment.
Please resolve the merge conflict and make sure it works
| optional double selfRateIn = 1; | ||
| optional double selfRateOut = 2; | ||
| repeated PeerInfo peers = 3; | ||
| } |
|
@dvmazur please take a look - you're way better at go than I am) |
justheuristic
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
My minor comments were resolved. Pending review from @dvmazur
|
Hey, will take a look at this PR by tomorrow evening. |
dvmazur
reviewed
Nov 29, 2023
| d.bandwidth_metrics = metrics.NewBandwidthCounter() | ||
| opts = append(opts, libp2p.BandwidthReporter(d.bandwidth_metrics)) | ||
| } else { | ||
| d.bandwidth_metrics = nil |
There was a problem hiding this comment.
nit: d.bandwidth_metrics are nil be default anyway.
ignore this comment if you wish
|
Other than the optional change I've suggested above, I have nothing to add to @justheuristic's comments. |
dvmazur
approved these changes
Nov 29, 2023
chiangmaioneluv
force-pushed
the
master
branch
from
bfd46ab
to
ed0708a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add basic bandwidth metrics + update protobuffs for communicating with hivemind